Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix broken legacy message view #26819

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

Fixed messagesHistory function, it was filtering messages only with existing threads.

Issue(s)

#26801

Steps to test or reproduce

Switch My Preferences > Global > Use legacy message template

Further comments

@hugocostadev hugocostadev added this to the 5.1.1 milestone Sep 6, 2022
@hugocostadev hugocostadev linked an issue Sep 6, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #26819 (92534e1) into develop (d44b74e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #26819   +/-   ##
========================================
  Coverage    40.53%   40.53%           
========================================
  Files          799      799           
  Lines        18296    18296           
  Branches      1954     1954           
========================================
  Hits          7417     7417           
+ Misses       10586    10582    -4     
- Partials       293      297    +4     
Flag Coverage Δ
e2e 40.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@alvaropmello alvaropmello modified the milestone: 5.1.1 Sep 6, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2022
@kodiakhq kodiakhq bot merged commit 94cc007 into develop Sep 6, 2022
@kodiakhq kodiakhq bot deleted the fix/legacy-message-parser branch September 6, 2022 14:42
tassoevan pushed a commit that referenced this pull request Sep 6, 2022
@tassoevan tassoevan mentioned this pull request Sep 6, 2022
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] legacy message template diplays nothing
4 participants